git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/5] t/t1304: set the mask ACL that is checked in check_perms_and_acl

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Mar 15, 2010, 17:37 UTC
Message-ID
<vpqy6ht5vvs.fsf@bauges.imag.fr>
In-Reply-To
<YowxgPZqaOkg2MZzY1CxLzeL4DIwxt_o3RKS9xen-cewKbECZA7OIb7mUaY2TbsVR_rHE5GTeU0@cipher.nrlssc.navy.mil>
Brandon Casey <casey@nrlssc.navy.mil> writes:
>  test_expect_success 'Setup test repo' '
>  	setfacl -m d:u::rwx,d:g::---,d:o:---,d:m:rwx $dirs_to_set &&
> +	setfacl -m m:rwx               $dirs_to_set &&

The patch sounds right, but I don't understand the commit message. You set m:rwx, and check_perms_and_acl expects mask::r--, so it's not exactly what check_perms_and_acl checks.

My understanding is that you set the mask here to enforce the validity of the ACL, but then you may want to just squash this into [PATCH 2/5].

But again, that's bikeshedding, the patch serie looks right to me. Sorry for not making the test right myself ;-).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Brandon CaseyNext: Brandon Casey
Message 8 of 12 in “tweak t1304 ACL tests so they work on Solaris”
  1. 0/5 tweak t1304 ACL tests so they work on SolarisBrandon Casey, Mar 15, 2010
  2. 1/5 t/t1304: avoid -d option to setfaclBrandon Casey, Mar 15, 2010
  3. 2/5 t/t1304: set the Default ACL base entriesBrandon Casey, Mar 15, 2010
  4. 3/5 t/t1304: use 'test -r' to test readability rather than looking at mode bitsBrandon Casey, Mar 15, 2010
  5. Matthieu MoyMar 15, 2010
  6. Brandon CaseyMar 15, 2010
  7. 4/5 t/t1304: set the mask ACL that is checked in check_perms_and_aclBrandon Casey, Mar 15, 2010
  8. Matthieu MoyMar 15, 2010
  9. Brandon CaseyMar 15, 2010
  10. 4/5 t/t1304: set the ACL effective rights maskBrandon Casey, Mar 15, 2010
  11. Matthieu MoyMar 15, 2010
  12. 5/5 t/t1304: make a second colon optional in the mask ACL checkBrandon Casey, Mar 15, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.