From: Thomas Rast <trast@inf.ethz.ch>
Date: Sat, 01 Jun 2013 14:19:22 GMT
Subject: Re: [PATCH] run-command: simplify wait_or_whine
Message-ID: <87wqqdoqvp.fsf@hexa.v.cablecom.net>
In-Reply-To: <1370094715-2684-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Nobody is checking for specific error codes; it's the errno that's
> important.
[...]
> -		/*
> -		 * This return value is chosen so that code & 0xff
> -		 * mimics the exit code that a POSIX shell would report for
> -		 * a program that died from this signal.
> -		 */
> -		code += 128;

Have you checked the callers?  There are lots of callers of
finish_command(), which returns the value from wait_or_whine()
unmodified.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch