Re: [PATCH v3 2/3] diff-merges: introduce '--dd' option
- From
Sergey Organov <sorganov@gmail.com>
- Date
- Oct 6, 2023, 17:05 UTC
- Message-ID
- <87v8bjr8a7.fsf@osv.gnss.ru>
- In-Reply-To
- <xmqqr0m8eoaq.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 16 quoted lines
> Sergey Organov <sorganov@gmail.com> writes: > >> This option provides a shortcut to request diff with respect to first >> parent for any kind of commit, universally. It's implemented as pure >> synonym for "--diff-merges=first-parent --patch". > > That explains what the patch does, but it does not tell us why it is > useful [*]. > >> NOTE: originally proposed as '-d', and renamed to '--dd' due to Junio >> request to keep "short-and-sweet" '-d' reserved for other uses. > > The note is not grammatical, and more importantly, readers of "git > log" 6 months down the road would not care. I'd rather not see it > in the proposed log message. It is suitable material to place after > the three-dash line, or in the cover letter for the iteration.
OK, will get rid of it.
Thanks, -- Sergey Organov