Re: [PATCH] git-send-email: add ~/.authinfo parsing
- From
Ted Zlatanov <tzz@lifelogs.com>
- Date
- Feb 4, 2013, 21:41 UTC
- Message-ID
- <87r4kvsqnc.fsf@lifelogs.com>
- In-Reply-To
- <20130204212203.GC13186@sigill.intra.peff.net>
On Mon, 4 Feb 2013 16:22:03 -0500 Jeff King <peff@peff.net> wrote:
Show 7 quoted lines
>> Currently, we map both the "port" and "protocol" netrc tokens to the >> credential helper protocol's "protocol". So this will have undefined >> results. To do what you specify could be pretty simple: we could do a >> preliminary scan of the tokens, looking for "host X port Y" where Y is >> an integer, and rewriting the host to be "X:Y". That would be clean and >> simple, unless the user breaks it with "host x:23 port 22". Let me know >> if you agree and I'll do.
JK> Yeah, I think that is simple and obvious. If the user is saying "host JK> x:23 port 22", that is nonsensical.
OK; added.
Ted