Re: [PATCH 3/3] Fix contrib/credentials/netrc minor issues: exit quietly; use 3-parameter open; etc.

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 4, 2013, 17:27 UTC
Message-ID: <7vfw1c2dm5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <87k3qovxlp.fsf_-_@lifelogs.com>

Ted Zlatanov <tzz@lifelogs.com> writes:

> Signed-off-by: Ted Zlatanov <tzz@lifelogs.com>
> ---
>  contrib/credential/netrc/git-credential-netrc |   38 +++++++++++++------------
>  1 files changed, 20 insertions(+), 18 deletions(-)

Especially because this is an initial submission, please equash three patches into one, instead of sending three "here is my first attempt with many problems I know I do not want to be there", "one small improvement", "another one to fix remaining issues".

Otherwise you will waste reviewers' time, getting distracted by undesirable details they find in an earlier patch while reviewing, without realizing that some of them are fixed in a later one.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.