git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] git-remote-mediawiki: use toplevel's Makefile

From
Matthieu Moy <matthieu.moy@imag.fr>
Date
Feb 8, 2013, 17:31 UTC
Message-ID
<1360344677-5962-2-git-send-email-Matthieu.Moy@imag.fr>
In-Reply-To
<1360344677-5962-1-git-send-email-Matthieu.Moy@imag.fr>

This makes the Makefile simpler, while providing more features, and more consistency (the exact same rules with the exact same configuration as Git official commands are applied with the new version).

Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 contrib/mw-to-git/.gitignore                       |  1 +
 contrib/mw-to-git/Makefile                         | 64 ++++++----------------
 ...-remote-mediawiki => git-remote-mediawiki.perl} |  0
 3 files changed, 18 insertions(+), 47 deletions(-)
 create mode 100644 contrib/mw-to-git/.gitignore
 rewrite contrib/mw-to-git/Makefile (96%)
 rename contrib/mw-to-git/{git-remote-mediawiki => git-remote-mediawiki.perl} (100%)
diff --git a/contrib/mw-to-git/.gitignore b/contrib/mw-to-git/.gitignore
new file mode 100644
index 0000000..b919655
--- /dev/null
+++ b/contrib/mw-to-git/.gitignore
@@ -0,0 +1 @@
+git-remote-mediawiki
diff --git a/contrib/mw-to-git/Makefile b/contrib/mw-to-git/Makefile
dissimilarity index 96%
index 3ed728b..f149719 100644
--- a/contrib/mw-to-git/Makefile
+++ b/contrib/mw-to-git/Makefile
@@ -1,47 +1,17 @@
-#
-# Copyright (C) 2012
-#     Charles Roussel <charles.roussel@ensimag.imag.fr>
-#     Simon Cathebras <simon.cathebras@ensimag.imag.fr>
-#     Julien Khayat <julien.khayat@ensimag.imag.fr>
-#     Guillaume Sasdy <guillaume.sasdy@ensimag.imag.fr>
-#     Simon Perrat <simon.perrat@ensimag.imag.fr>
-#
-## Build git-remote-mediawiki
-
--include ../../config.mak.autogen
--include ../../config.mak
-
-ifndef PERL_PATH
-	PERL_PATH = /usr/bin/perl
-endif
-ifndef gitexecdir
-	gitexecdir = $(shell git --exec-path)
-endif
-
-PERL_PATH_SQ = $(subst ','\'',$(PERL_PATH))
-gitexecdir_SQ = $(subst ','\'',$(gitexecdir))
-SCRIPT = git-remote-mediawiki
-
-.PHONY: install help doc test clean
-
-help:
-	@echo 'This is the help target of the Makefile. Current configuration:'
-	@echo '  gitexecdir = $(gitexecdir_SQ)'
-	@echo '  PERL_PATH = $(PERL_PATH_SQ)'
-	@echo 'Run "$(MAKE) install" to install $(SCRIPT) in gitexecdir'
-	@echo 'Run "$(MAKE) test" to run the testsuite'
-
-install:
-	sed -e '1s|#!.*/perl|#!$(PERL_PATH_SQ)|' $(SCRIPT) \
-		> '$(gitexecdir_SQ)/$(SCRIPT)'
-	chmod +x '$(gitexecdir)/$(SCRIPT)'
-
-doc:
-	@echo 'Sorry, "make doc" is not implemented yet for $(SCRIPT)'
-
-test:
-	$(MAKE) -C t/ test
-
-clean:
-	$(RM) '$(gitexecdir)/$(SCRIPT)'
-	$(MAKE) -C t/ clean
+#
+# Copyright (C) 2013
+#     Matthieu Moy <Matthieu.Moy@imag.fr>
+#
+## Build git-remote-mediawiki
+
+SCRIPT_PERL=git-remote-mediawiki.perl
+GIT_ROOT_DIR=../..
+HERE=contrib/mw-to-git/
+
+SCRIPT_PERL_FULL=$(patsubst %,$(HERE)/%,$(SCRIPT_PERL))
+
+all: build
+
+build install clean:
+	$(MAKE) -C $(GIT_ROOT_DIR) SCRIPT_PERL=$(SCRIPT_PERL_FULL) \
+                $@-perl-script
diff --git a/contrib/mw-to-git/git-remote-mediawiki b/contrib/mw-to-git/git-remote-mediawiki.perl
similarity index 100%
rename from contrib/mw-to-git/git-remote-mediawiki
rename to contrib/mw-to-git/git-remote-mediawiki.perl
-- 
1.8.1.2.530.g3cc16e4.dirty
Previous: Matthieu MoyNext: Matthieu Moy
Message 64 of 78 in “git-send-email: add ~/.authinfo parsing”
  1. git-send-email: add ~/.authinfo parsingMichal Nazarewicz, Jan 29, 2013
  2. Junio C HamanoJan 29, 2013
  3. [PATCHv2] git-send-email: add ~/.authinfo parsingMichal Nazarewicz, Jan 29, 2013
  4. Junio C HamanoJan 29, 2013
  5. [PATCHv3] git-send-email: add ~/.authinfo parsingMichal Nazarewicz, Jan 30, 2013
  6. Junio C HamanoJan 30, 2013
  7. Jeff KingJan 30, 2013
  8. Junio C HamanoJan 30, 2013
  9. Ted ZlatanovJan 31, 2013
  10. Jeff KingJan 31, 2013
  11. Ted ZlatanovFeb 2, 2013
  12. Jeff KingFeb 3, 2013
  13. Ted ZlatanovFeb 4, 2013
  14. 1/3 Add contrib/credentials/netrc with GPG supportTed Zlatanov, Feb 4, 2013
  15. Ted ZlatanovFeb 4, 2013
  16. Junio C HamanoFeb 4, 2013
  17. Ted ZlatanovFeb 4, 2013
  18. Junio C HamanoFeb 4, 2013
  19. Ted ZlatanovFeb 4, 2013
  20. Junio C HamanoFeb 4, 2013
  21. CodingGuidelines Perl amendment (was: [PATCH 1/3] Add contrib/credentials/netrc with GPG support)Ted Zlatanov, Feb 6, 2013
  22. Junio C HamanoFeb 6, 2013
  23. demerphqFeb 6, 2013
  24. Ted ZlatanovFeb 6, 2013
  25. Junio C HamanoFeb 6, 2013
  26. demerphqFeb 6, 2013
  27. Update CodingGuidelines for Perl 5Ted Zlatanov, Feb 6, 2013
  28. Ted ZlatanovFeb 6, 2013
  29. Junio C HamanoFeb 6, 2013
  30. Ted ZlatanovFeb 6, 2013
  31. demerphqFeb 6, 2013
  32. Ted ZlatanovFeb 6, 2013
  33. demerphqFeb 6, 2013
  34. Ted ZlatanovFeb 6, 2013
  35. Junio C HamanoFeb 6, 2013
  36. Update CodingGuidelines for Perl 5Ted Zlatanov, Feb 6, 2013
  37. 2/3 Skip blank and commented lines in contrib/credentials/netrcTed Zlatanov, Feb 4, 2013
  38. 3/3 Fix contrib/credentials/netrc minor issues: exit quietly; use 3-parameter open; etc.Ted Zlatanov, Feb 4, 2013
  39. Junio C HamanoFeb 4, 2013
  40. Ted ZlatanovFeb 4, 2013
  41. Michal NazarewiczFeb 4, 2013
  42. Ted ZlatanovFeb 4, 2013
  43. Jeff KingFeb 4, 2013
  44. Ted ZlatanovFeb 4, 2013
  45. Jeff KingFeb 4, 2013
  46. Ted ZlatanovFeb 4, 2013
  47. Jeff KingFeb 4, 2013
  48. Ted ZlatanovFeb 4, 2013
  49. Junio C HamanoFeb 5, 2013
  50. Matthieu MoyFeb 6, 2013
  51. Ted ZlatanovFeb 6, 2013
  52. Matthieu MoyFeb 6, 2013
  53. Ted ZlatanovFeb 6, 2013
  54. Matthieu MoyFeb 6, 2013
  55. Ted ZlatanovFeb 6, 2013
  56. 0/4 Allow contrib/ to use Git's Makefile for perl codeMatthieu Moy, Feb 6, 2013
  57. 1/4 Makefile: extract perl-related rules to make them available from other dirsMatthieu Moy, Feb 6, 2013
  58. Junio C HamanoFeb 7, 2013
  59. 2/4 perl.mak: introduce $(GIT_ROOT_DIR) to allow inclusion from other directoriesMatthieu Moy, Feb 6, 2013
  60. 3/4 Makefile: factor common configuration in git-default-config.makMatthieu Moy, Feb 6, 2013
  61. Junio C HamanoFeb 7, 2013
  62. Matthieu MoyFeb 8, 2013
  63. 1/2 Makefile: make script-related rules usable from subdirectoriesMatthieu Moy, Feb 8, 2013
  64. 2/2 git-remote-mediawiki: use toplevel's MakefileMatthieu Moy, Feb 8, 2013
  65. 4/4 git-remote-mediawiki: use Git's Makefile to build the scriptMatthieu Moy, Feb 6, 2013
  66. Junio C HamanoFeb 7, 2013
  67. Jeff KingFeb 8, 2013
  68. Matthieu MoyFeb 8, 2013
  69. Jeff KingFeb 8, 2013
  70. Junio C HamanoFeb 8, 2013
  71. Jeff KingFeb 8, 2013
  72. Jeff KingFeb 6, 2013
  73. Ted ZlatanovFeb 6, 2013
  74. Matthieu MoyFeb 7, 2013
  75. Ted ZlatanovFeb 7, 2013
  76. Michal NazarewiczFeb 6, 2013
  77. Ted ZlatanovFeb 6, 2013
  78. Ted ZlatanovJan 30, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.