Re: [PATCH] gitweb: Do not use absolute font sizes

From: David Kågedal <davidk@lysator.liu.se>
Date: May 15, 2007, 01:06 UTC
Message-ID: <87odkmgaj5.fsf@morpheus.local>
In-Reply-To: <f2a3si$ein$1@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> writes:

Show 23 quoted lines

> Petr Baudis wrote:
>
>> Note that this patch actually does change visual look of gitweb in Firefox
>> with my resolution and default settings - everything is bigger and I can't
>> explain the joy of actually seeing gitweb text that is in _readable_ size;
>> also, my horizontal screen real estate feels better used now.
>
> Not everyone has those huge monitors with extreme resultion. For me new
> gitweb look uses much to big font, so not very much fits in screen.
>
> I'd remove 
>
>> --- a/gitweb/gitweb.css
>> +++ b/gitweb/gitweb.css
>> @@ -1,6 +1,5 @@
>>  body {
>>         font-family: sans-serif;
>> -       font-size: 12px;
>>         border: solid #d9d8d1;
>>         border-width: 1px;
>>         margin: 10px;
>
> chunk

But then we'd be back to the brain-damaged explicit-pixel sizes.

gitweb is simply using the font size you have configured your browser to use, and if you think that it too large, you are free to reconfigure it.

Unfortunately, the problem is that too many web sites explicitly select extra small font sizes, which means that you have to select a "standard" font size in your browser that is a bit larger than you'd actually like.

-- 
David Kågedal