Re: [PATCH] gitweb: Do not use absolute font sizes

From: Jakub Narebski <jnareb@gmail.com>
Date: May 15, 2007, 23:59 UTC
Message-ID: <200705160159.55590.jnareb@gmail.com>
In-Reply-To: <20070515150912.GA3653@efreet.light.src>

On Thu, 15 May 2007, Jan Hudec wrote:

> On Mon, May 14, 2007 at 18:06:54 -0700, David Kågedal wrote:

Show 11 quoted lines

>> Unfortunately, the problem is that too many web sites explicitly
>> select extra small font sizes, which means that you have to select a
>> "standard" font size in your browser that is a bit larger than you'd
>> actually like.
> 
> IMHO gitweb should explicitely request being somewhat smaller than normal,
> because it has good use for long lines. Normally I want to set font so large,
> that more than ~120 characters won't fit on the screen, since otherwise pages
> that don't use margins are simply unreadable. However gitweb presents a table
> with several columns, so having wider line is OK for it. Therefore explicit
> 'font-size: small' would make sense.

And thanks to commit 63fcbe00 by Pasky
  "gitweb: Do not use absolute font sizes"
it has to be added in only one place:

diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
index b57c8be..02623cb 100644
--- a/gitweb/gitweb.css
+++ b/gitweb/gitweb.css
@@ -1,5 +1,6 @@
 body {
 	font-family: sans-serif;
+	font-size: small;
 	border: solid #d9d8d1;
 	border-width: 1px;
 	margin: 10px;