git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitweb: Change base font size to "small"

From
Jakub Narebski <jnareb@gmail.com>
Date
May 16, 2007, 10:51 UTC
Message-ID
<200705161251.38729.jnareb@gmail.com>
In-Reply-To
<20070515150912.GA3653@efreet.light.src>
Commit 63fcbe00a66d7cb7d8bce9a36120a19a809a33b8 by Peter "Pasky" Baudis
  "gitweb: Do not use absolute font sizes"
made gitweb use default font size, the font size you have configured
your browser to use, as a basis; other font sizes are given as
percentage.

David Kågedal noticed problem with this approach: too many web sites explicitly select extra small font sizes, which means that you have to select a "standard" font size in your browser that is a bit larger than one would actually like.

Additionally, as Jan Hudec noticed, gitweb should explicitely request being somewhat smaller than normal, because it has good use for long lines. Normally one would usually want to set font so large, that more than ~120 characters won't fit on the screen, since otherwise pages that don't use margins are simply unreadable. However gitweb presents a table with several columns, so having wider line is OK for it.

Jan Hudec proposed to use 'font-size: small' to take above issues into account. This avoid using "brain-damaged" explicit-pixel sizes, while taking into account nature of gitweb output.

Thanks to mentioned commit by Pasky we need to add 'font-size: small' in only one place, for BODY element.

See the original messages:
  Message-ID: <87odkmgaj5.fsf@morpheus.local>
  Message-ID: <20070515150912.GA3653@efreet.light.src>
Proposed-by: Jan Hudec <bulb@ucw.cz>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This is commit wich has commit message larger than patch itself, but
I think the explanation is as important as patch itself, perhaps even
more important.
 gitweb/gitweb.css |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
index b57c8be..02623cb 100644
--- a/gitweb/gitweb.css
+++ b/gitweb/gitweb.css
@@ -1,5 +1,6 @@
 body {
 	font-family: sans-serif;
+	font-size: small;
 	border: solid #d9d8d1;
 	border-width: 1px;
 	margin: 10px;
-- 
1.5.1.4
Previous: Jakub NarebskiNext: Petr Baudis
Message 13 of 16 in “gitweb css - pixels?!”
  1. Chris RiddochMay 7, 2007
  2. Allan WindMay 8, 2007
  3. Chris RiddochMay 8, 2007
  4. Jan HudecMay 8, 2007
  5. gitweb: Do not use absolute font sizesPetr Baudis, May 9, 2007
  6. Junio C HamanoMay 9, 2007
  7. Petr BaudisMay 9, 2007
  8. Chris RiddochMay 9, 2007
  9. Jakub NarebskiMay 14, 2007
  10. David KågedalMay 15, 2007
  11. Jan HudecMay 15, 2007
  12. Jakub NarebskiMay 15, 2007
  13. gitweb: Change base font size to "small"Jakub Narebski, May 16, 2007
  14. Petr BaudisMay 17, 2007
  15. Junio C HamanoMay 17, 2007
  16. Jakub NarebskiMay 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.