git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: Do not use absolute font sizes

From
Junio C Hamano <junkio@cox.net>
Date
May 9, 2007, 05:54 UTC
Message-ID
<7vvef2y21o.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20070509014150.7477.48489.stgit@rover>
Petr Baudis <pasky@ucw.cz> writes:
Show 8 quoted lines
> Avoid specifying font sizes in pixels, since that is just pure evil.
> Pointed out by Chris Riddoch.
>
> Note that this is pretty much just a proposal; I didn't test if everything
> fits perfectly right, but things seem to be pretty much okay. repo.or.cz
> uses it now as a test drive - if you find any visual quirks, please point
> them out, with a patch if possible since I'm total CSS noob and debugging
> CSS is an extremely painful experience for me.
This looks like going in the right direction, but...
Show 32 quoted lines
>  gitweb/gitweb.css |   19 +++++++++----------
>  1 files changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
> index 6c662a1..df12d78 100644
> --- a/gitweb/gitweb.css
> +++ b/gitweb/gitweb.css
> @@ -1,6 +1,5 @@
>  body {
>  	font-family: sans-serif;
> -	font-size: 12px;
>  	border: solid #d9d8d1;
>  	border-width: 1px;
>  	margin: 10px;
> @@ -31,7 +30,7 @@ img.logo {
>  div.page_header {
>  	height: 25px;
>  	padding: 8px;
> -	font-size: 18px;
> +	font-size: 150%;
>  	font-weight: bold;
>  	background-color: #d9d8d1;
>  }
> @@ -113,7 +112,7 @@ span.signoff {
>  
>  div.log_link {
>  	padding: 0px 8px;
> -	font-size: 10px;
> +	font-size: 70%;
>  	font-family: sans-serif;
>  	font-style: normal;
>  	position: relative;
	[12, 18, 10] / 12 * 100 = [100, 150, 83.33]
why not use 83% for what were originally 10px?
Previous: Petr BaudisNext: Petr Baudis
Message 6 of 16 in “gitweb css - pixels?!”
  1. Chris RiddochMay 7, 2007
  2. Allan WindMay 8, 2007
  3. Chris RiddochMay 8, 2007
  4. Jan HudecMay 8, 2007
  5. gitweb: Do not use absolute font sizesPetr Baudis, May 9, 2007
  6. Junio C HamanoMay 9, 2007
  7. Petr BaudisMay 9, 2007
  8. Chris RiddochMay 9, 2007
  9. Jakub NarebskiMay 14, 2007
  10. David KågedalMay 15, 2007
  11. Jan HudecMay 15, 2007
  12. Jakub NarebskiMay 15, 2007
  13. gitweb: Change base font size to "small"Jakub Narebski, May 16, 2007
  14. Petr BaudisMay 17, 2007
  15. Junio C HamanoMay 17, 2007
  16. Jakub NarebskiMay 17, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.