Re: [PATCH] gitweb: Do not use absolute font sizes
Petr Baudis <pasky@ucw.cz> writes:
Show 8 quoted lines
> Avoid specifying font sizes in pixels, since that is just pure evil.
> Pointed out by Chris Riddoch.
>
> Note that this is pretty much just a proposal; I didn't test if everything
> fits perfectly right, but things seem to be pretty much okay. repo.or.cz
> uses it now as a test drive - if you find any visual quirks, please point
> them out, with a patch if possible since I'm total CSS noob and debugging
> CSS is an extremely painful experience for me.
This looks like going in the right direction, but...
Show 32 quoted lines
> gitweb/gitweb.css | 19 +++++++++----------
> 1 files changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
> index 6c662a1..df12d78 100644
> --- a/gitweb/gitweb.css
> +++ b/gitweb/gitweb.css
> @@ -1,6 +1,5 @@
> body {
> font-family: sans-serif;
> - font-size: 12px;
> border: solid #d9d8d1;
> border-width: 1px;
> margin: 10px;
> @@ -31,7 +30,7 @@ img.logo {
> div.page_header {
> height: 25px;
> padding: 8px;
> - font-size: 18px;
> + font-size: 150%;
> font-weight: bold;
> background-color: #d9d8d1;
> }
> @@ -113,7 +112,7 @@ span.signoff {
>
> div.log_link {
> padding: 0px 8px;
> - font-size: 10px;
> + font-size: 70%;
> font-family: sans-serif;
> font-style: normal;
> position: relative; [12, 18, 10] / 12 * 100 = [100, 150, 83.33]
why not use 83% for what were originally 10px?