Re: [PATCH v2 1/3] Move init_skiplist() outside of fsck
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jan 18, 2019, 09:45 UTC
- Message-ID
- <87k1j247ui.fsf@evledraar.gmail.com>
- In-Reply-To
- <20190117202919.157326-2-brho@google.com>
On Thu, Jan 17 2019, Barret Rhoden wrote:
> - die("Could not open skip list: %s", path);
> [...]
> + die("Could not open skip list: %s", path);You're just moving this around, but now that this has two uses let's say "Could not open SHA-1 list; %s" or something like that.
> + die("Invalid SHA-1: %s", sb.buf);Unlike Johannes I think it's fine to leave this. This file-format is SHA-1 only now. We can cross the bridge of making it (and others) SHA-256 somehow when we come to that, whether that'll be allowing variable width or a different file.