Re: [PATCH] blame: add the ability to ignore commits

From: Barret Rhoden <brho@google.com>
Date: Jan 14, 2019, 19:03 UTC
Message-ID: <20190114140330.0fe3e382@gnomeregan.cam.corp.google.com>
In-Reply-To: <003c01d4ac36$bdf29470$39d7bd50$@nexbridge.com>

On 2019-01-14 at 13:26 "Randall S. Becker" <rsbecker@nexbridge.com> wrote:

Show 15 quoted lines

> > 
> > Sorry, I made a too-fuzzy statement.  What I meant was, that unless you  
> are
> > ignoring E, I do not know why you "would want to" attribute a line "foo(x,  
> y,
> > z)" that appears in F to X.  Starting from X up to D (and to Y in real  
> history, but
> > you are ignoring Y), the line was "foo(x,y,z)", after E, it is "foo(x, y,  
> z)".  I
> > didn't mean to ask how you "would show" such a result---as I do not yet
> > understand why you would want such a result to begin with.  
> 
> From my own community, this came up also. The intent was to show everyone
> who touched a particular line, throughout history, not just the current one.
> Perhaps that is what Barret is going for.

Yeah. I want to find the most recent commit that changed a line, minus a set of commits that are deemed 'not interesting' by the user.

The primary reason for this is to not see a blame attributed to a commit that does nothing but reformatting the code base.

One could also use this feature for one-off investigation with the command-line switch. Imagine a manually driven git-blame + git-log, where you do a git-blame, check the commit, decide you want to see the next one back, and rerun git-blame with --skip-rev=SHA1.

The Chromium depot_tools has a python tool that can do this, called hyper-blame: (https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html).

I thought it was a useful feature for all of git's users. And I also didn't want people to have to install depot_tools.

Barret