Re: [PATCH v2 2/3] blame: add the ability to ignore commits and their changes

From: Barret Rhoden <brho@google.com>
Date: Jan 18, 2019, 17:33 UTC
Message-ID: <20190118123349.346ca2d1@gnomeregan.cam.corp.google.com>
In-Reply-To: <nycvar.QRO.7.76.6.1901181038540.41@tvgsbejvaqbjf.bet>

On 2019-01-18 at 10:47 Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 10 quoted lines

> ... and this change limit the user to specifying a single file, for no
> good reason. Worse: specifying two different files via two
> `--ignore-revs-file` parameters will only heed the latter and skip the
> former without any warning.
> 
> A better idea IMHO would be to use an OPT_STRING_LIST() for
> `--ignore-revs-file`, too, and to allow for multiple
> `blame.ignoreRevsFile` config entries (with our usual trick of handling an
> empty setting by resetting the list of paths that were accumulated so
> far, see e.g. how `credential.helper` is handled).

I can do this if you all want, though I was modeling it off the behavior of -S, which also only takes a single file.

Thanks, everyone, for all of the feedback.

Barret