git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: --diff-filter=T does not list x changes

From
AMAnders Melchiorsen <mail@cup.kalibalik.dk>
Date
Oct 17, 2008, 07:08 UTC
Message-ID
<87ej2fvgv9.fsf@kalibalik.dk>
In-Reply-To
<7vhc7cq8uq.fsf@gitster.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
> Jeff King <peff@peff.net> writes:
>
>>   Select only files [...] have their type (mode) changed (T) [...]
>>
>> which to me indicates that your test case should work. 
>
> That documentation is quite loosely written. Typechange diff is what
> T has always meant, and it never was about the executable bit. The
> word "mode" in that sentence only means the upper bits
> S_IFREG/S_IFLNK (iow, masked by S_IFMT).

I hope you agree that this reading is not obvious from the documentation, so I will send a patch later fixing up the prose (if nobody beats me to it).

How about adding a diff-filter=X for the executable bit? I could probably look at that during the weekend.

Anders.
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 13 in “--diff-filter=T does not list x changes”
  1. Anders MelchiorsenOct 15, 2008
  2. Jeff KingOct 16, 2008
  3. Junio C HamanoOct 17, 2008
  4. Anders MelchiorsenOct 17, 2008
  5. Junio C HamanoOct 17, 2008
  6. Anders MelchiorsenOct 17, 2008
  7. Junio C HamanoOct 17, 2008
  8. Documentation: diff-filter=T only tests for symlink changesAnders Melchiorsen, Oct 18, 2008
  9. Nanako ShiraishiOct 18, 2008
  10. Junio C HamanoOct 18, 2008
  11. Junio C HamanoOct 18, 2008
  12. Nanako ShiraishiOct 19, 2008
  13. Anders MelchiorsenOct 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.