Re: --diff-filter=T does not list x changes

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 17, 2008, 02:00 UTC
Message-ID: <7vhc7cq8uq.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20081016102201.GB20762@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Wed, Oct 15, 2008 at 08:42:35PM +0200, Anders Melchiorsen wrote:
>
>> From documentation, I would expect --diff-filter to list changes in
>> the execute bit, but it does not. I hear on #git that this is
>> intended, though I still do not know how to filter on the execute bit.
>> Is it impossible?
>
> Looking at the code, I think it's impossible, and one would have to add
> a new --diff-filter letter. However, at the very least, the
> documentation should clarify this situation. The --diff-filter
> explanation says:
>
>   Select only files [...] have their type (mode) changed (T) [...]
>
> which to me indicates that your test case should work.

That documentation is quite loosely written. Typechange diff is what T has always meant, and it never was about the executable bit. The word "mode" in that sentence only means the upper bits S_IFREG/S_IFLNK (iow, masked by S_IFMT).