From: Anders Melchiorsen Date: Fri, 17 Oct 2008 07:08:10 GMT Subject: Re: --diff-filter=T does not list x changes Message-ID: <87ej2fvgv9.fsf@kalibalik.dk> In-Reply-To: <7vhc7cq8uq.fsf@gitster.siamese.dyndns.org> Junio C Hamano writes: > Jeff King writes: > >> Select only files [...] have their type (mode) changed (T) [...] >> >> which to me indicates that your test case should work. > > That documentation is quite loosely written. Typechange diff is what > T has always meant, and it never was about the executable bit. The > word "mode" in that sentence only means the upper bits > S_IFREG/S_IFLNK (iow, masked by S_IFMT). I hope you agree that this reading is not obvious from the documentation, so I will send a patch later fixing up the prose (if nobody beats me to it). How about adding a diff-filter=X for the executable bit? I could probably look at that during the weekend. Anders.