git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Documentation: diff-filter=T only tests for symlink changes

From
Nanako Shiraishi <nanako3@lavabit.com>
Date
Oct 19, 2008, 01:04 UTC
Message-ID
<20081019100454.6117@nanako3.lavabit.com>
In-Reply-To
<87vdvq5lu4.fsf_-_@cup.kalibalik.dk>
Quoting Junio C Hamano <gitster@pobox.com>:
Show 30 quoted lines
>
> Nanako Shiraishi <nanako3@lavabit.com> writes:
>
>> Quoting Anders Melchiorsen <mail@cup.kalibalik.dk>:
>>
>>> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
>>> index 7788d4f..7604a13 100644
>>> --- a/Documentation/diff-options.txt
>>> +++ b/Documentation/diff-options.txt
>>> @@ -137,7 +137,7 @@ endif::git-format-patch[]
>>>  --diff-filter=[ACDMRTUXB*]::
>>>  	Select only files that are Added (`A`), Copied (`C`),
>>>  	Deleted (`D`), Modified (`M`), Renamed (`R`), have their
>>> -	type (mode) changed (`T`), are Unmerged (`U`), are
>>> +	type (symlink/regular file) changed (`T`), are Unmerged (`U`), are
>>>  	Unknown (`X`), or have had their pairing Broken (`B`).
>>>  	Any combination of the filter characters may be used.
>>>  	When `*` (All-or-none) is added to the combination, all
>>> -- 
>>> 1.6.0.2.514.g23abd3
>>
>> Are symlinks and regular files the only kind of object you can see in
>> diff? What happens when a file or directory changes to a submodule?
>
> Oops.  I've already applied Anders's patch, but you are right.  A change
> from a blob to submodule also shows up as a typechange event.
>
> Perhaps we should just remove the parenthesised comment from there
> instead.  I'll rewind and rebuild, as I haven't pushed the results out
> yet (lucky me).
I see that you pushed out this change already, and you changed your mind and described them all.  I think the result reads better.
-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/
Previous: Junio C HamanoNext: Anders Melchiorsen
Message 12 of 13 in “--diff-filter=T does not list x changes”
  1. Anders MelchiorsenOct 15, 2008
  2. Jeff KingOct 16, 2008
  3. Junio C HamanoOct 17, 2008
  4. Anders MelchiorsenOct 17, 2008
  5. Junio C HamanoOct 17, 2008
  6. Anders MelchiorsenOct 17, 2008
  7. Junio C HamanoOct 17, 2008
  8. Documentation: diff-filter=T only tests for symlink changesAnders Melchiorsen, Oct 18, 2008
  9. Nanako ShiraishiOct 18, 2008
  10. Junio C HamanoOct 18, 2008
  11. Junio C HamanoOct 18, 2008
  12. Nanako ShiraishiOct 19, 2008
  13. Anders MelchiorsenOct 19, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.