git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] send-email: add test for duplicate utf8 name

From
Thomas Rast <trast@inf.ethz.ch>
Date
Jun 20, 2013, 12:41 UTC
Message-ID
<87a9ml9cou.fsf@linux-k42r.v.cablecom.net>
In-Reply-To
<1371731166-24015-2-git-send-email-mst@redhat.com>
"Michael S. Tsirkin" <mst@redhat.com> writes:
> Verify that author name is not duplicated if it matches
> sender, even if it is in utf8.

Small nit: if you make two patches out of it, add the tests first with test_expect_failure. Then flip it to test_expect_success in the actual code change. That makes it easy to verify that the test actually checks the right thing, and that it was your code change that fixed it.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Michael S. TsirkinNext: Michael S. Tsirkin
Message 3 of 7 in “send-email: sanitize author when writing From line”
  1. 1/2 send-email: sanitize author when writing From lineMichael S. Tsirkin, Jun 20, 2013
  2. 2/2 send-email: add test for duplicate utf8 nameMichael S. Tsirkin, Jun 20, 2013
  3. Thomas RastJun 20, 2013
  4. Michael S. TsirkinJun 20, 2013
  5. Thomas RastJun 20, 2013
  6. Michael S. TsirkinJun 20, 2013
  7. Junio C HamanoJun 20, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.