git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/2] send-email: add test for duplicate utf8 name

From
MTMichael S. Tsirkin <mst@redhat.com>
Date
Jun 20, 2013, 12:27 UTC
Message-ID
<1371731166-24015-2-git-send-email-mst@redhat.com>
In-Reply-To
<1371731166-24015-1-git-send-email-mst@redhat.com>

Verify that author name is not duplicated if it matches sender, even if it is in utf8.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 t/t9001-send-email.sh | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 9f46f22..020acc4 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -956,6 +956,20 @@ test_expect_success $PREREQ 'utf8 author is correctly passed on' '
 	grep "^From: Füñný Nâmé <odd_?=mail@example.com>" msgtxt1
 '
 
+test_expect_success $PREREQ 'utf8 sender is not duplicated' '
+	clean_fake_sendmail &&
+	test_commit weird_sender &&
+	test_when_finished "git reset --hard HEAD^" &&
+	git commit --amend --author "Füñný Nâmé <odd_?=mail@example.com>" &&
+	git format-patch --stdout -1 >funny_name.patch &&
+	git send-email --from="Füñný Nâmé <odd_?=mail@example.com>" \
+	  --to=nobody@example.com \
+	  --smtp-server="$(pwd)/fake.sendmail" \
+	  funny_name.patch &&
+	grep "^From:" msgtxt1 > msgfrom &&
+	test_line_count = 1 msgfrom
+'
+
 test_expect_success $PREREQ 'sendemail.composeencoding works' '
 	clean_fake_sendmail &&
 	git config sendemail.composeencoding iso-8859-1 &&
-- 
MST
Previous: Michael S. TsirkinNext: Thomas Rast
Message 2 of 7 in “send-email: sanitize author when writing From line”
  1. 1/2 send-email: sanitize author when writing From lineMichael S. Tsirkin, Jun 20, 2013
  2. 2/2 send-email: add test for duplicate utf8 nameMichael S. Tsirkin, Jun 20, 2013
  3. Thomas RastJun 20, 2013
  4. Michael S. TsirkinJun 20, 2013
  5. Thomas RastJun 20, 2013
  6. Michael S. TsirkinJun 20, 2013
  7. Junio C HamanoJun 20, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.