From: Thomas Rast Date: Thu, 20 Jun 2013 12:41:37 GMT Subject: Re: [PATCH v2 2/2] send-email: add test for duplicate utf8 name Message-ID: <87a9ml9cou.fsf@linux-k42r.v.cablecom.net> In-Reply-To: <1371731166-24015-2-git-send-email-mst@redhat.com> "Michael S. Tsirkin" writes: > Verify that author name is not duplicated if it matches > sender, even if it is in utf8. Small nit: if you make two patches out of it, add the tests first with test_expect_failure. Then flip it to test_expect_success in the actual code change. That makes it easy to verify that the test actually checks the right thing, and that it was your code change that fixed it. -- Thomas Rast trast@{inf,student}.ethz.ch