Re: [PATCH v2 2/2] send-email: add test for duplicate utf8 name

From: Michael S. Tsirkin <mst@redhat.com>
Date: Jun 20, 2013, 12:45 UTC
Message-ID: <20130620124502.GA24172@redhat.com>
In-Reply-To: <87a9ml9cou.fsf@linux-k42r.v.cablecom.net>

On Thu, Jun 20, 2013 at 02:41:37PM +0200, Thomas Rast wrote:

Show 9 quoted lines

> "Michael S. Tsirkin" <mst@redhat.com> writes:
> 
> > Verify that author name is not duplicated if it matches
> > sender, even if it is in utf8.
> 
> Small nit: if you make two patches out of it, add the tests first with
> test_expect_failure.  Then flip it to test_expect_success in the actual
> code change.  That makes it easy to verify that the test actually checks
> the right thing, and that it was your code change that fixed it.

I did this by reverting 1/2 and rerunning.

But applying in reverse order means bisect can give us a setup where some tests fail, I thought it's a good idea to avoid that.

> -- 
> Thomas Rast
> trast@{inf,student}.ethz.ch