Re: [PATCH 3/4] t5510: ensure we stay in the toplevel test dir

From: Thomas Rast <trast@inf.ethz.ch>
Date: Mar 1, 2012, 22:09 UTC
Message-ID: <871upcht2h.fsf@thomas.inf.ethz.ch>
In-Reply-To: <7vipiokmrz.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 17 quoted lines

> Thomas Rast <trast@student.ethz.ch> writes:
>
>> The last test descended into a subdir without ever re-emerging, which
>> is not so nice to the next test writer.
>
> True.  Making the test suite more robust like this patch does is very much
> appreciated.
>
> Is there a reason why we shouldn't be sticking to the more usual
>
> 	mkdir dups &&
>         (
>         	cd dups &&
>                 do whatever in dups
> 	)
>
> pattern?

None in particular. It would also perhaps reduce the churn since (as it touches every line anyway) it could be squashed with 2/4. Should I reroll?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch