git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] bundle: keep around names passed to add_pending_object()

From
Thomas Rast <trast@inf.ethz.ch>
Date
Mar 1, 2012, 22:22 UTC
Message-ID
<87obsggdwh.fsf@thomas.inf.ethz.ch>
In-Reply-To
<7vehtckmee.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 12 quoted lines
> Thomas Rast <trast@student.ethz.ch> writes:
>
>> The 'name' field passed to add_pending_object() is used to later
>> deduplicate in object_array_remove_duplicates().
>>
>> git-bundle had a bug in this area since 18449ab (git-bundle: avoid
>> packing objects which are in the prerequisites, 2007-03-08): it passed
>> the name of each boundary object in a static buffer.  In other words,
>> all that object_array_remove_duplicates() saw was the name of the
>> *last* added boundary object.
>
> Ouch.

Actually, I just noticed that object_array_remove_duplicates() is much newer than 18449ab, from b2a6d1c (bundle: allow the same ref to be given more than once, 2009-01-17). However it did pass in the same buffer all the time starting from 18449ab, which is a bug waiting to happen (and perhaps NULL would have been more appropriate).

Archaeology sure is fun.
-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Junio C Hamano
Message 11 of 11 in “Another bundle fix: reading freed memory”
  1. 0/4 Another bundle fix: reading freed memoryThomas Rast, Mar 1, 2012
  2. 1/4 t5510: refactor bundle->pack conversionThomas Rast, Mar 1, 2012
  3. 2/4 t5510: fix indent with spacesThomas Rast, Mar 1, 2012
  4. 3/4 t5510: ensure we stay in the toplevel test dirThomas Rast, Mar 1, 2012
  5. Junio C HamanoMar 1, 2012
  6. Thomas RastMar 1, 2012
  7. Junio C HamanoMar 1, 2012
  8. Junio C HamanoMar 1, 2012
  9. 4/4 bundle: keep around names passed to add_pending_object()Thomas Rast, Mar 1, 2012
  10. Junio C HamanoMar 1, 2012
  11. Thomas RastMar 1, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.