Re: [PATCH v4 05/10] commit-graph: always load commit-graph information

From: Jakub Narebski <jnareb@gmail.com>
Date: Apr 29, 2018, 22:18 UTC
Message-ID: <86y3h5hd1i.fsf@gmail.com>
In-Reply-To: <20180425143735.240183-6-dstolee@microsoft.com>

[Forgot about one thing]

Derrick Stolee <dstolee@microsoft.com> writes:

> Create new load_commit_graph_info() method to fill in the information
> for a commit that exists only in the commit-graph file.

The above sentence is a bit hard to parse because of ambiguity: is it "the information" that exists only in the commit-graph file, or "a commit" that exists only in the commit-graph file?

Show 6 quoted lines

>                                                          Call it from
> parse_commit_buffer() after loading the other commit information from
> the given buffer. Only fill this information when specified by the
> 'check_graph' parameter.
>
> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>

-- 
Jakub Narębski

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.