Re: [PATCH 3/6] commit-graph: compute generation numbers

From

JTJonathan Tan <jonathantanmy@google.com>

Date

Apr 3, 2018, 18:30 UTC

Message-ID

<20180403113010.170ef6a14b0c126f99651bc4@google.com>

In-Reply-To

<20180403165143.80661-4-dstolee@microsoft.com>

> +		if ((*list)->generation != GENERATION_NUMBER_UNDEF) {
> +			if ((*list)->generation > GENERATION_NUMBER_MAX)
> +				die("generation number %u is too large to store in commit-graph",
> +				    (*list)->generation);
> +			packedDate[0] |= htonl((*list)->generation << 2);
> +		}

The die() should have "BUG:" if you agree with my comment below.

> +static void compute_generation_numbers(struct commit** commits,
> +				       int nr_commits)

Style: space before **, not after.

> +			if (all_parents_computed) {
> +				current->generation = max_generation + 1;
> +				pop_commit(&list);
> +			}