Re: [PATCH] gitweb: Add "next" link to commitdiff view
- From
Junio C Hamano <junkio@cox.net>
- Date
- Oct 28, 2006, 19:00 UTC
- Message-ID
- <7vzmbg8dum.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <200610281810.36892.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
Show 23 quoted lines
> Jakub Narebski wrote: >> Add a kind of "next" view in the bottom part of navigation bar for >> "commitdiff" view. >> >> For commitdiff between two commits: >> (from: _commit_) >> For commitdiff for one single parent commit: >> (parent: _commit_) >> For commitdiff for one merge commit >> (merge: _commit_ _commit_ ...) >> For commitdiff for root (parentless) commit >> (initial) >> where _link_ denotes hyperlink. SHA1 is shortened to 7 characters on >> display, everything is perhaps unnecessary esc_html on display. >> >> Signed-off-by: Jakub Narebski <jnareb@gmail.com> >> --- >> >> Junio (and others), is it what you wanted? The idea was to change >> "commitdiff" view only in minimal way, and preserve similarity >> to "commit" format. > > Any reasons not to accept this patch?
Nothing other than it was lost in the noise (I am partly responsible for) that followed the patch.
Message-ID: <200610230037.57183.jnareb@gmail.com>
Who acked this in the discussion? I'd like to add "Acked-by:" for them when I make the commit.