Re: [PATCH] gitweb: Add "next" link to commitdiff view

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 29, 2006, 01:58 UTC
Message-ID: <200610290258.31771.jnareb@gmail.com>
In-Reply-To: <196807.75961.qm@web31801.mail.mud.yahoo.com>

Luben Tuikov wrote:

Show 15 quoted lines

> --- Jakub Narebski <jnareb@gmail.com> wrote:
>> Jakub Narebski wrote:
>>> Add a kind of "next" view in the bottom part of navigation bar for
>>> "commitdiff" view.
>>> 
>>> For commitdiff between two commits:
>>>   (from: _commit_)
>>> For commitdiff for one single parent commit:
>>>   (parent: _commit_)
>>> For commitdiff for one merge commit
>>>   (merge: _commit_ _commit_ ...)
>>> For commitdiff for root (parentless) commit
>>>   (initial)
>>> where _link_ denotes hyperlink. SHA1 is shortened to 7 characters on
>>> display, everything is perhaps unnecessary esc_html on display.

[...]

Show 14 quoted lines

>> 
>> Any reasons not to accept this patch? I find it very useful.
>> 
>> The idea to use fixed string instead of shortened SHA-1 of commit
>> was abandoned after some discussion in this thread.
> 
> I prefer using the commit-8 without any "..." postfixed.  Anyone who
> knows squat about git knows very well what a commit-8 is when they
> see one -- the first 8 hexadecimal digits of the full SHA-1.
> 
> I like using "next" only when there is a "prev" right next to it,
> i.e. based on _context_, something like this:
>    << prev next>>
> where "<< prev" is hyperlinked, and "next>>" is also.

Unfortunately this is simply not possible in this case, as links in git are only from commit to paren(a), in one direction only.

Besides as you can see we can have more than one "next>>" link: for merge commit there are multiple parents. Well, for branch points there are multiple commits which have given commit as (one of) its parent(s), so there can be multiple "<<prev" links as well.

Show 5 quoted lines

> I looked at your patch (first email in this thread) and from
> what I gathered that it does, I like it (haven't tried it yet).
> 
> What I like about it is the clear information it conveys:
> it gives me both the commit-8 and what that commit-8 _is_.

It is commit-7, but that can be easily changed.

> Acked-by: Luben Tuikov <ltuikov@yahoo.com>
> (not that it matters in any way ;-) )

IIRC Junio asked for ACKs.

-- 
Jakub Narebski