Re: [PATCH] gitweb: Add "next" link to commitdiff view

From: Luben Tuikov <ltuikov@yahoo.com>
Date: Oct 29, 2006, 01:50 UTC
Message-ID: <196807.75961.qm@web31801.mail.mud.yahoo.com>
In-Reply-To: <200610281810.36892.jnareb@gmail.com>

--- Jakub Narebski <jnareb@gmail.com> wrote:

Show 26 quoted lines

> Jakub Narebski wrote:
> > Add a kind of "next" view in the bottom part of navigation bar for
> > "commitdiff" view.
> > 
> > For commitdiff between two commits:
> >   (from: _commit_)
> > For commitdiff for one single parent commit:
> >   (parent: _commit_)
> > For commitdiff for one merge commit
> >   (merge: _commit_ _commit_ ...)
> > For commitdiff for root (parentless) commit
> >   (initial)
> > where _link_ denotes hyperlink. SHA1 is shortened to 7 characters on
> > display, everything is perhaps unnecessary esc_html on display.
> > 
> > Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> > ---
> > 
> > Junio (and others), is it what you wanted? The idea was to change
> > "commitdiff" view only in minimal way, and preserve similarity
> > to "commit" format.
> 
> Any reasons not to accept this patch? I find it very useful.
> 
> The idea to use fixed string instead of shortened SHA-1 of commit
> was abandoned after some discussion in this thread.

I prefer using the commit-8 without any "..." postfixed. Anyone who knows squat about git knows very well what a commit-8 is when they see one -- the first 8 hexadecimal digits of the full SHA-1.

I like using "next" only when there is a "prev" right next to it,
i.e. based on _context_, something like this:
   << prev next >>
where "<< prev" is hyperlinked, and "next >>" is also.

I looked at your patch (first email in this thread) and from what I gathered that it does, I like it (haven't tried it yet).

What I like about it is the clear information it conveys: it gives me both the commit-8 and what that commit-8 _is_.

I sometimes remember commit-8s and this helps me a lot when I move the mouse pointer to an xterm and want to do git-show <commit-8>, and it futhermore helps me _know_ the relationship between that commit-8 and the rest of the information in the window frame gitweb is showing, (parent, etc).

Acked-by: Luben Tuikov <ltuikov@yahoo.com>
(not that it matters in any way ;-) )

   Luben