Re: [PATCH] gitweb: Add "next" link to commitdiff view

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 28, 2006, 16:10 UTC
Message-ID: <200610281810.36892.jnareb@gmail.com>
In-Reply-To: <200610230037.57183.jnareb@gmail.com>

Jakub Narebski wrote:

Show 20 quoted lines

> Add a kind of "next" view in the bottom part of navigation bar for
> "commitdiff" view.
> 
> For commitdiff between two commits:
>   (from: _commit_)
> For commitdiff for one single parent commit:
>   (parent: _commit_)
> For commitdiff for one merge commit
>   (merge: _commit_ _commit_ ...)
> For commitdiff for root (parentless) commit
>   (initial)
> where _link_ denotes hyperlink. SHA1 is shortened to 7 characters on
> display, everything is perhaps unnecessary esc_html on display.
> 
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> 
> Junio (and others), is it what you wanted? The idea was to change
> "commitdiff" view only in minimal way, and preserve similarity
> to "commit" format.

Any reasons not to accept this patch? I find it very useful.

The idea to use fixed string instead of shortened SHA-1 of commit was abandoned after some discussion in this thread.

-- 
Jakub Narebski