Re: [RFC/PATCH] shell: allow 'help' command to disable interactive shell

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 11, 2013, 07:28 UTC
Message-ID: <7vzjzbnwb7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAE_TNin+WcPodGfXKQuzBVujK7Yx3iCUR2rqgoc20WgwhJSR4g@mail.gmail.com>

Ethan Reesor <firelizzard@gmail.com> writes:

Show 12 quoted lines

> On Mon, Feb 11, 2013 at 2:22 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Ethan Reesor <firelizzard@gmail.com> writes:
>>> Again, would it not be more elegant and powerful to A) have the
>>> shell-disabled message/hook/etc specified by git-config on some level,
>>> be it /etc/gitconfig or ~/.gitconfig, and B) have Jonathan's patch
>>> whereby ~/git-shell-commands/help returning non-zero closes the
>>> connection?
>>
>> Isn't that what I have essentially been saying?
>
> That is what you've been saying. I reiterated because I like the idea
> of having it managed via git config.

Yes, and I've been ignoring the "git config". I do not think it gives enough customizability Jonathan's example of listing user owned repositories, for example. Having a config variable in /etc/gitconfig that points at a random script on the filesystem does not buy us much over an approach to have a global hook at a known place on the filesystem, no?