Re: [RFC/PATCH] shell: allow 'help' command to disable interactive shell

From

Jonathan Nieder <jrnieder@gmail.com>

Date

Feb 11, 2013, 04:14 UTC

Message-ID

<20130211041404.GA15329@elie.Belkin>

In-Reply-To

<20130211035908.GA4543@sigill.intra.peff.net>

Jeff King wrote:

> On Sun, Feb 10, 2013 at 05:20:16PM -0800, Jonathan Nieder wrote:

>> +When run interactively (with no arguments), 'git-shell' will
>> +automatically run `~/git-shell-commands/help` on startup, provided it
>> +exists.  If the 'help' command fails then the interactive shell is
>> +aborted.
>
> Doesn't that mean that people who currently do allow interactive access
> and have a ~/git-shell-commands/help (that returns zero) will get
> spammed by its as a motd each time they connect?

Only interactive connections.  That's the existing behavior.

[...]

> What about "ssh example.com foo"? Do we want to allow a custom message
> there, too (it might be different there; e.g., an allowed list of
> commands might make more sense)?

I wouldn't mind, but it's definitely not my itch.