From: Junio C Hamano Date: Mon, 11 Feb 2013 07:28:44 GMT Subject: Re: [RFC/PATCH] shell: allow 'help' command to disable interactive shell Message-ID: <7vzjzbnwb7.fsf@alter.siamese.dyndns.org> In-Reply-To: Ethan Reesor writes: > On Mon, Feb 11, 2013 at 2:22 AM, Junio C Hamano wrote: >> Ethan Reesor writes: >>> Again, would it not be more elegant and powerful to A) have the >>> shell-disabled message/hook/etc specified by git-config on some level, >>> be it /etc/gitconfig or ~/.gitconfig, and B) have Jonathan's patch >>> whereby ~/git-shell-commands/help returning non-zero closes the >>> connection? >> >> Isn't that what I have essentially been saying? > > That is what you've been saying. I reiterated because I like the idea > of having it managed via git config. Yes, and I've been ignoring the "git config". I do not think it gives enough customizability Jonathan's example of listing user owned repositories, for example. Having a config variable in /etc/gitconfig that points at a random script on the filesystem does not buy us much over an approach to have a global hook at a known place on the filesystem, no?