Re: [RFC/PATCH] shell: allow 'help' command to disable interactive shell
- From
Jeff King <peff@peff.net>
- Date
- Feb 11, 2013, 04:36 UTC
- Message-ID
- <20130211043629.GB12735@sigill.intra.peff.net>
- In-Reply-To
- <20130211043247.GD15329@elie.Belkin>
On Sun, Feb 10, 2013 at 08:32:47PM -0800, Jonathan Nieder wrote:
Show 5 quoted lines
> Junio C Hamano wrote: > > > Are you shooting for customizability? > > Yes, and the ability to generate the message dynamically.
As far as the default goes, I think the current one is OK, provided there is an option to customize it (e.g., like your patch). Right now it is just nonsensical to random users ("What? What in the world is ~/git-shell-commands?"). But once it is customizable, the main consumer of the message is admins who say "What? Why isn't the git-shell I just set up working?". The current message helps them diagnose the problem, and when they are ready to accept connections from random users, they'll want something customizable anyway.
-Peff