Re: [PATCH] wt-status: show author info if status.showauthor is set

From: Junio C Hamano <junkio@cox.net>
Date: Apr 4, 2007, 06:32 UTC
Message-ID: <7vy7l87iq8.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070404062447.GA4136@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> Signed-off-by: Jeff King <peff@peff.net>
> ---
> On Wed, Apr 04, 2007 at 09:02:13AM +0300, Michael S. Tsirkin wrote:
>
>> - Maybe put Author: (or From:? and maybe Subject:?) line in the pre-formatted
>>   commit message, and let the user edit them?
>
> Personally I think it's just clutter, but hey, it's off by default. Of
> course what is the chance that you've turned on status.showauthor in
> your ~/.gitconfig, but you don't have your identity set up properly? :)
>
> Junio, this is somewhat tongue in cheek, but if people like it, please
> take it.

It may be t-i-c, but on the other hand it might make sense to make git-commit take notice and use it.

If we were to go that route, I suspect it should not be of form "# author: Who AmI <who.ami@example.com>".

Maybe the updated git-commit commit log message rule could be:

 * If the lines in the first paragraph all begin with "From: ",
   or "Date: " (you do not have to override all of them), they
   are used to override authorship information;

 * If this feature is used, "Subject: " should be among the
   lines in the first paragraph for consistency.

 * Otherwise we will continue doing what we always have been
   doing.