Re: [PATCH] display the subject of the commit just made

From: Michael S. Tsirkin <mst@dev.mellanox.co.il>
Date: Apr 16, 2007, 06:18 UTC
Message-ID: <20070416061813.GD23255@mellanox.co.il>
In-Reply-To: <7vodlox3fx.fsf@assigned-by-dhcp.cox.net>

Show 27 quoted lines

> Quoting Junio C Hamano <junkio@cox.net>:
> Subject: Re: [PATCH] display the subject of the commit just made
> 
> "Michael S. Tsirkin" <mst@dev.mellanox.co.il> writes:
> 
> > Display the subject of the commit just made.
> >
> > Useful e.g. to figure out what I did from screen history,
> > or to make sure subject line is short enough and makes sense
> > on its own.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@dev.mellanox.co.il>
> >
> > ---
> >
> >> Quoting Junio C Hamano <junkio@cox.net>:
> >> Close but no cigar.  You broke it for a merge commit, I think.
> >> 
> >> Perhaps
> >> 
> >> 	pretty="format:Created${initial_commit:+ initial} commit %h: %s%n"
> >> 	git-diff-tree --always --shortstart --summary --root --pretty="$pretty" HEAD
> >
> > OK, thanks fo rpointing this out.
> > But why the extra %n at the end?
> 
> Because I *got* *rid* *of* "echo".

Oh. But, this seems to stick an extra newline before the shortstart summary, instead of at the end. No?

 ./git-commit.sh --amend
Created commit 63cfb8c: test more

 1 files changed, 1 insertions(+), 1 deletions(-)

while in my version

 ./git-commit.sh --amend
Created commit 63cfb8c: test more
 1 files changed, 1 insertions(+), 1 deletions(-)

so I think we are stuck with echo.

-- 
MST