Re: [PATCH] display the subject of the commit just made

From: Junio C Hamano <junkio@cox.net>
Date: Apr 16, 2007, 06:17 UTC
Message-ID: <7vejmkx2qf.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070416054059.GB23255@mellanox.co.il>

"Michael S. Tsirkin" <mst@dev.mellanox.co.il> writes:

> BTW, a couple of questions:
> 1. do we really need the shortstat info?

I am between neutral to slightly negative, so I won't miss it if it is removed, but I'll let people who wanted it to defend it.

> 2. why is there "--" at the end do in the original version?

Blame is always your friend.

	$ git blame -L'/^git-diff-tree .*--$/,1' git-commit.sh

finds that it came from this commit:

commit 521f9c4def9430526bfdfffdb8ed4c2f4166bece
Author: Michael Loeffler <zvpunry@zvpunry.de>
Date:   Mon Jan 8 20:23:13 2007 +0100

    git-commit: do not fail to print the diffstat even if there is a file named HEAD
    
    Signed-off-by: Michael Loeffler <zvpunry@zvpunry.de>
    Signed-off-by: Junio C Hamano <junkio@cox.net>

diff --git a/git-commit.sh b/git-commit.sh
index 04aad5e..c2beb76 100755
--- a/git-commit.sh
+++ b/git-commit.sh
@@ -628,7 +628,7 @@ then
 	if test -z "$quiet"
 	then
 		echo "Created${initial_commit:+ initial} commit $commit"
-		git-diff-tree --shortstat --summary --root --no-commit-id HEAD
+		git-diff-tree --shortstat --summary --root --no-commit-id HEAD --
 	fi
 fi