Re: [PATCH] display shortlog after git-commit

From: Michael S. Tsirkin <mst@dev.mellanox.co.il>
Date: Apr 15, 2007, 20:09 UTC
Message-ID: <20070415200939.GC15208@mellanox.co.il>
In-Reply-To: <7v4pnh4dip.fsf@assigned-by-dhcp.cox.net>

Show 25 quoted lines

> Quoting Junio C Hamano <junkio@cox.net>:
> Subject: Re: [PATCH] display shortlog after git-commit
> 
> "Michael S. Tsirkin" <mst@dev.mellanox.co.il> writes:
> 
> >> I think a much better thing you could do is to have a mode that
> >> the commit log message editor is started with something like
> >> this...
> >
> > This would work well for author information, but less well for shortlog.
> >
> >> 	----------------------------------------------------------------
> >> 	From: A U Thor <au.thor@example.com>
> >>      Subject: << one line summary of the commit comes here >>
> >>         
> >> 	<< more detailed explanations come here >>
> >> 	# Please enter the commit message for your changes.
> >>      # (comment lines starting with '#' will not be included)
> 
> Care to share your reasoning behind "less well for shortlog" part?
> 
> I think a template like the above makes absolutely clear that
> your log would look like a single summary line, and a separate
> body of text that explains your change fully, and I do not
> understand your concern.

I confess that I forget to add shortlog line myself sometimes, and I feel that adding stuff inside comments won't help me remember since I'm used to ignoring it.

Current git commit output looks like this:
	Created commit 2b7ca2abf7526f13ce334475e0c66f79fbb5c206
	1 files changed, 1 insertions(+), 0 deletions(-)

And I wander why does it tell me the new commit hash - wouldn't displaying the subject make more sense? Something like

	Created commit "Make foobar faster by caching more barbar in foo"
	1 files changed, 1 insertions(+), 0 deletions(-)

-- 
MST