Re: git notes: notes

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 20, 2010, 22:07 UTC
Message-ID: <7vy6jszaz0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100120214152.GC9107@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> diff --git a/pretty.c b/pretty.c
> index 0674027..95fe39a 100644
> --- a/pretty.c
> +++ b/pretty.c
> @@ -1094,7 +1094,8 @@ void pretty_print_commit(enum cmit_fmt fmt, const struct commit *commit,
>  	if (fmt == CMIT_FMT_EMAIL && sb->len <= beginning_of_body)
>  		strbuf_addch(sb, '\n');
>  
> -	if (fmt != CMIT_FMT_ONELINE && fmt != CMIT_FMT_RAW)
> +	if (context->show_notes ||
> +	    (fmt != CMIT_FMT_ONELINE && fmt != CMIT_FMT_RAW))
>  		get_commit_notes(commit, sb, encoding,
>  				 NOTES_SHOW_HEADER | NOTES_INDENT);

Heh, without this hunk I would have thought Peff and Gitster were the same person ;-).

Once you introduce --no-notes, the above condition would not work well.