Re: git notes: notes

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 20, 2010, 21:08 UTC
Message-ID: <7veilk1o3s.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4B576F5C.2050102@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

Show 15 quoted lines

> Junio C Hamano venit, vidit, dixit 20.01.2010 21:10:
>> Joey Hess <joey@kitenet.net> writes:
>> 
>>> Do you think it makes sense for even git log --format=format:%s to be
>>> porcelain and potentially change when new features are used?
>> 
>> If the series changed the meaning of "%s" format to mean "the subject of
>> the commit and notes information", with or without documenting it, then it
>> is just a bug we would like to fix.
>
> No, but outputting the note as part of the log is the standard. So for
> example, when you do a format-patch | apply cycle, format-patch will
> insert the note as part of the commit message, and apply will *store*
> the note text (including Note:\n) as part of the commit message of the
> new commit.

Thanks; that was the kind of breakage report I was looking for (and wished to have heard a lot earlier). Personally I find it is unexcusable that format-patch defaults to giving notes.

> So, I would say the notes feature is not that well integrated right now,

No question about it.

> I'm not complaining, I actually have this on a maybe-to-do list, but the
> way the series went kept me from investing time.

Hmm, that hints there is a failure in the review and merge process. Care to explain how we could have done better please?