Re: git notes: notes
- From
Johan Herland <johan@herland.net>
- Date
- Jan 21, 2010, 02:05 UTC
- Message-ID
- <201001210305.05309.johan@herland.net>
- In-Reply-To
- <20100120182438.GB31507@gnu.kitenet.net>
On Wednesday 20 January 2010, Joey Hess wrote:
Show 9 quoted lines
> Johan Herland wrote: > > > PS, Has anyone thought about using notes to warn bisect away from > > > commits that are known to be unbuildable or otherwise cause bisection > > > trouble? > > > > No, I haven't thought of that specific use case. Great idea! :) > > Only problem I see with doing it is it might be too easy to overwrite > such a note with git notes edit -m
Well, you would have to run "git notes edit -m" with core.notesRef or $GIT_NOTES_REF set to the notes ref where bisect information is stored (e.g. "refs/notes/bisect").
In any case, I would not use "git notes" to maintain the bisect hints. Rather, I'd add subcommands to "git bisect" that would take care of maintaining the notes tree @ "refs/notes/bisect". Much more user-friendly than telling the user to write their own bisect-notes by hand.
> Did you consider having -m append a line to an existing note?
Hmm. Not really. The "git notes" porcelain was originally written by Dscho, and my builtin-ification of it (currently in 'pu') preserves the original semantics of "git notes edit -m". It might make sense to change the defaults; what do you think, Dscho?
Have fun! :)
...Johan
-- Johan Herland, <johan@herland.net> www.herland.net