Re: [PATCH 3/5] git-diff.txt: group the [--] and [<path>...] templates

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 24, 2013, 19:21 UTC
Message-ID: <7vy5c7buqn.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALkWK0nN+9XOTCqiY+yB9moQSvFFpSO=OZjJtLphBd2eQ24uDw@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

Show 25 quoted lines

> Junio C Hamano wrote:
>> The same logic would apply to this semi-nonsense rewrite, no?
>>
>>         git diff [[options] [--]] [<path>...]
>>
>> Everything else comes before "--" (if exists) that separates it from
>> the list of pathspecs.
>
> Yeah, except it's sometimes
>
>     [[options] [revision range] [--]] [<path>...]
>
> and other times
>
>     [[options] [<commit>...] [--]] [<path>...]
>
> and yet other times
>
>     [[options] [--]] [<path>...]
>
> Whereas mine is always
>
>     ... [[--] [<path>]]
>
> (everywhere in git)

You are missing the entire point. Neither [[everything else][--]][path] or [everything else][[--][path]] is better than without the extra level of [], which does not help clarifying _anything_.