Re: [PATCH 1/5] git-diff.txt: reorder the <commit> <commit> form

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Apr 24, 2013, 16:41 UTC
Message-ID: <20130424164142.GC4119@elie.Belkin>
In-Reply-To: <1366821216-20868-2-git-send-email-artagnon@gmail.com>

Ramkumar Ramachandra wrote:

> In DESCRIPTION, the '<commit>..<commit>' form refers to "the previous
> form", namely the '<commit> <commit>' form.  However, bd52900

Good catch.

[...]

Show 10 quoted lines

> --- a/Documentation/git-diff.txt
> +++ b/Documentation/git-diff.txt
> @@ -11,8 +11,8 @@ SYNOPSIS
>  [verse]
>  'git diff' [options] [<commit>] [--] [<path>...]
>  'git diff' [options] --cached [<commit>] [--] [<path>...]
> -'git diff' [options] <commit> <commit> [--] [<path>...]
>  'git diff' [options] <blob> <blob>
> +'git diff' [options] <commit> <commit> [--] [<path>...]
>  'git diff' [options] [--no-index] [--] <path> <path>

For the sake of exposition I think it makes more sense to put <commit> <commit> *before* <blob> <blob>, since the former is used more often.

Thanks, Jonathan