Re: [PATCH 3/5] git-diff.txt: group the [--] and [<path>...] templates

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 24, 2013, 18:43 UTC
Message-ID: <7vbo93db25.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALkWK0nU-iTSF2DnmJAB=kj6w+VFv3rQrixEnHz0vyXf2d2=Mw@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

Show 10 quoted lines

> Junio C Hamano wrote:
>>> -'git diff' [options] [--] [<path>...]::
>>> +'git diff' [options] [[--] [<path>...]]::
>>
>> While the update might be logically more correct, it looks to me
>> that the only end-user visibile effect of it is to make the end
>> result harder to read.
>
> Hm, I thought it improves readability.  I'm trying to say that -- is
> used to separate [<path>...] from [everything else].

The same logic would apply to this semi-nonsense rewrite, no?

	git diff [[options] [--]] [<path>...]

Everything else comes before "--" (if exists) that separates it from the list of pathspecs.