Re: [PATCH/RFC v3 11/16] When debug==1, start fast-import with "--stats" instead of "--quiet".

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 15, 2012, 19:50 UTC
Message-ID: <7vwr103pg1.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1344971598-8213-12-git-send-email-florian.achleitner.2.6.31@gmail.com>

Florian Achleitner <florian.achleitner.2.6.31@gmail.com> writes:

Show 5 quoted lines

> fast-import prints statistics that could be interesting to the
> developer of remote helpers.
>
> Signed-off-by: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
> ---

Sounds sensible and could be useful outside the context of this series. Perhaps place it earlier in the series?

Show 16 quoted lines

>  transport-helper.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/transport-helper.c b/transport-helper.c
> index 257274b..7fb52d4 100644
> --- a/transport-helper.c
> +++ b/transport-helper.c
> @@ -386,7 +386,7 @@ static int get_importer(struct transport *transport, struct child_process *fasti
>  	memset(fastimport, 0, sizeof(*fastimport));
>  	fastimport->in = helper->out;
>  	argv_array_push(&argv, "fast-import");
> -	argv_array_push(&argv, "--quiet");
> +	argv_array_push(&argv, debug ? "--stats" : "--quiet");
>  
>  	if (data->bidi_import) {
>  		cat_blob_fd = xdup(helper->in);