Re: [PATCH/RFC v3 07/16] Add a symlink 'git-remote-svn' in base dir.

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 14, 2012, 20:46 UTC
Message-ID: <7vvcgl8amk.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1344971598-8213-8-git-send-email-florian.achleitner.2.6.31@gmail.com>

Florian Achleitner <florian.achleitner.2.6.31@gmail.com> writes:

Show 17 quoted lines

> Allow execution of git-remote-svn even if the binary
> currently is located in contrib/svn-fe/.
>
> Signed-off-by: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
> ---
>  git-remote-svn |    1 +
>  1 file changed, 1 insertion(+)
>  create mode 120000 git-remote-svn
>
> diff --git a/git-remote-svn b/git-remote-svn
> new file mode 120000
> index 0000000..d3b1c07
> --- /dev/null
> +++ b/git-remote-svn
> @@ -0,0 +1 @@
> +contrib/svn-fe/remote-svn
> \ No newline at end of file

Please scratch my previous comment. I thought you were adding an entry to .gitignore or something.

I'd rather not to see such a symbolic link that points at a build product in the source tree. Making a symlink from the toplevel Makefile _after_ we built it in contrib/svn-fe/ (and removing it upon "make clean") is OK, though.