git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC v3 10/16] Create a note for every imported commit containing svn metadata.

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 15, 2012, 19:49 UTC
Message-ID
<7v1uj85427.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1344971598-8213-11-git-send-email-florian.achleitner.2.6.31@gmail.com>
Florian Achleitner <florian.achleitner.2.6.31@gmail.com> writes:
Show 29 quoted lines
> To provide metadata from svn dumps for further processing, e.g.
> branch detection, attach a note to each imported commit that
> stores additional information.
> The notes are currently hard-coded in refs/notes/svn/revs.
> Currently the following lines from the svn dump are directly
> accumulated in the note. This can be refined on purpose, of course.
> - "Revision-number"
> - "Node-path"
> - "Node-kind"
> - "Node-action"
> - "Node-copyfrom-path"
> - "Node-copyfrom-rev"
>
> Signed-off-by: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
> ---
>  vcs-svn/fast_export.c |   13 +++++++++++++
>  vcs-svn/fast_export.h |    2 ++
>  vcs-svn/svndump.c     |   21 +++++++++++++++++++--
>  3 files changed, 34 insertions(+), 2 deletions(-)
>
> diff --git a/vcs-svn/fast_export.c b/vcs-svn/fast_export.c
> index 1ecae4b..796dd1a 100644
> --- a/vcs-svn/fast_export.c
> +++ b/vcs-svn/fast_export.c
> @@ -12,6 +12,7 @@
>  #include "svndiff.h"
>  #include "sliding_window.h"
>  #include "line_buffer.h"
> +#include "cache.h"

Shouldn't it be near the beginning? Also if you include "cache.h", it probably makes git-compat-util and strbuf redundant.

Show 11 quoted lines
>  
>  #define MAX_GITSVN_LINE_LEN 4096
>  
> @@ -68,6 +69,18 @@ void fast_export_modify(const char *path, uint32_t mode, const char *dataref)
>  	putchar('\n');
>  }
>  
> +void fast_export_begin_note(uint32_t revision, const char *author,
> +		const char *log, unsigned long timestamp)
> +{
> +	timestamp = 1341914616;
The magic number needs some comment.
> +	size_t loglen = strlen(log);

decl-after-statement. I am starting to suspect that the assignment is a leftover from an earlier debugging effort, though.

Previous: Junio C HamanoNext: Florian Achleitner
Message 23 of 36 in “GSOC remote-svn”
  1. 00/16 GSOC remote-svnFlorian Achleitner, Aug 14, 2012
  2. 01/16 Implement a remote helper for svn in C.Florian Achleitner, Aug 14, 2012
  3. 02/16 Integrate remote-svn into svn-fe/Makefile.Florian Achleitner, Aug 14, 2012
  4. 03/16 Add svndump_init_fd to allow reading dumps from arbitrary FDs.Florian Achleitner, Aug 14, 2012
  5. 04/16 Connect fast-import to the remote-helper via pipe, adding 'bidi-import' capability.Florian Achleitner, Aug 14, 2012
  6. 05/16 Add documentation for the 'bidi-import' capability of remote-helpers.Florian Achleitner, Aug 14, 2012
  7. 06/16 remote-svn, vcs-svn: Enable fetching to private refs.Florian Achleitner, Aug 14, 2012
  8. 07/16 Add a symlink 'git-remote-svn' in base dir.Florian Achleitner, Aug 14, 2012
  9. 08/16 Allow reading svn dumps from files via file:// urls.Florian Achleitner, Aug 14, 2012
  10. 09/16 vcs-svn: add fast_export_note to create notesFlorian Achleitner, Aug 14, 2012
  11. 10/16 Create a note for every imported commit containing svn metadata.Florian Achleitner, Aug 14, 2012
  12. 11/16 When debug==1, start fast-import with "--stats" instead of "--quiet".Florian Achleitner, Aug 14, 2012
  13. 12/16 remote-svn: add incremental import.Florian Achleitner, Aug 14, 2012
  14. 13/16 Add a svnrdump-simulator replaying a dump file for testing.Florian Achleitner, Aug 14, 2012
  15. 14/16 transport-helper: add import|export-marks to fast-import command line.Florian Achleitner, Aug 14, 2012
  16. 15/16 remote-svn: add marks-file regeneration.Florian Achleitner, Aug 14, 2012
  17. 16/16 Add a test script for remote-svn.Florian Achleitner, Aug 14, 2012
  18. Florian AchleitnerAug 15, 2012
  19. Junio C HamanoAug 15, 2012
  20. Florian AchleitnerAug 15, 2012
  21. Florian AchleitnerAug 15, 2012
  22. Junio C HamanoAug 15, 2012
  23. Junio C HamanoAug 15, 2012
  24. Florian AchleitnerAug 15, 2012
  25. Junio C HamanoAug 14, 2012
  26. Junio C HamanoAug 14, 2012
  27. Florian AchleitnerAug 15, 2012
  28. Junio C HamanoAug 14, 2012
  29. Florian AchleitnerAug 15, 2012
  30. Junio C HamanoAug 15, 2012
  31. Junio C HamanoAug 14, 2012
  32. Junio C HamanoAug 14, 2012
  33. Florian AchleitnerAug 15, 2012
  34. Junio C HamanoAug 14, 2012
  35. Florian AchleitnerAug 15, 2012
  36. David Michael BarrAug 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.