Re: [PATCH 6/8] sh-setup: make die_with_status clear GIT_REFLOG_ACTION

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 18, 2013, 16:37 UTC
Message-ID: <7vwqpr5q9q.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CALkWK0kE1g5k=TxJCBQoHi+o7SZD5skQ2s6utxEgeuK=_C9ULg@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

> Please excuse my stupidity and drop this patch.

Heh, we always have brain-fart every once in a while. Your stupidity is always gladly excused ;-)

> I got mislead by your SQUASH??? patch which took care to set the
> environment variable and call checkout in a subshell.

To some, we could have done

	ENV_VAR="$ENV_VAR: some other string" command

but there were uses of "output" shell function in some instances, and

	VAR=VAL shell_function

does not work, so that was the reason why

	(
        	VAR=VAL; export VAR
                shell_function
	)

form was used.