git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/8] checkout: respect GIT_REFLOG_ACTION

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 18, 2013, 16:53 UTC
Message-ID
<7vli675pi8.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1371557670-12534-6-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra <artagnon@gmail.com> writes:
Show 8 quoted lines
> Fix the failing tests in t/checkout-last by making checkout respect it
> too.  You can now expect
>
>   $ git checkout -
>
> to work as expected after any a rebase [-i].  It will also work with any
> other scripts provided they set an appropriate GIT_REFLOG_ACTION if they
> internally use "git checkout".

Yes, it is better to clearly say that this just opens the door to fix others and at this step "rebase" is the primary thing that is fixed.

By the way, please stop doing "t/checkout-last" which I have to manually fix-up every time to its actual prefix (i.e. I cannot review with "less t/checkout-last*" to see what the log message is talking about; I can with "less t/t2012-checkout-last*").

Previous: Ramkumar RamachandraNext: Ramkumar Ramachandra
Message 8 of 15 in “Re-roll rr/rebase-checkout-reflog”
  1. 0/8 Re-roll rr/rebase-checkout-reflogRamkumar Ramachandra, Jun 18, 2013
  2. 1/8 t/status-help: test "HEAD detached from"Ramkumar Ramachandra, Jun 18, 2013
  3. 2/8 wt-status: remove unused field in grab_1st_switch_cbdataRamkumar Ramachandra, Jun 18, 2013
  4. 3/8 t/checkout-last: test "checkout -" after a rebaseRamkumar Ramachandra, Jun 18, 2013
  5. 4/8 status: do not depend on rebase reflog messagesRamkumar Ramachandra, Jun 18, 2013
  6. Peter KreftingJun 18, 2013
  7. 5/8 checkout: respect GIT_REFLOG_ACTIONRamkumar Ramachandra, Jun 18, 2013
  8. Junio C HamanoJun 18, 2013
  9. Ramkumar RamachandraJun 18, 2013
  10. 6/8 sh-setup: make die_with_status clear GIT_REFLOG_ACTIONRamkumar Ramachandra, Jun 18, 2013
  11. Junio C HamanoJun 18, 2013
  12. Ramkumar RamachandraJun 18, 2013
  13. Junio C HamanoJun 18, 2013
  14. 7/8 rebase: write better reflog messagesRamkumar Ramachandra, Jun 18, 2013
  15. 8/8 rebase -i: write better reflog messagesRamkumar Ramachandra, Jun 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.