git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 6/8] sh-setup: make die_with_status clear GIT_REFLOG_ACTION

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Jun 18, 2013, 12:14 UTC
Message-ID
<1371557670-12534-7-git-send-email-artagnon@gmail.com>
In-Reply-To
<1371557670-12534-1-git-send-email-artagnon@gmail.com>

Several callers set GIT_REFLOG_ACTION via set_reflog_action(), but nobody unsets it, leaving a potentially stray variable in the environment. Fix this by making die_with_status() unset it.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
 git-sh-setup.sh | 1 +
 1 file changed, 1 insertion(+)
diff --git a/git-sh-setup.sh b/git-sh-setup.sh
index 2f78359..3297103 100644
--- a/git-sh-setup.sh
+++ b/git-sh-setup.sh
@@ -51,6 +51,7 @@ die () {
 }
 
 die_with_status () {
+	export GIT_REFLOG_ACTION=
 	status=$1
 	shift
 	echo >&2 "$*"
-- 
1.8.3.1.456.gb7f4cb6
Previous: Ramkumar RamachandraNext: Junio C Hamano
Message 10 of 15 in “Re-roll rr/rebase-checkout-reflog”
  1. 0/8 Re-roll rr/rebase-checkout-reflogRamkumar Ramachandra, Jun 18, 2013
  2. 1/8 t/status-help: test "HEAD detached from"Ramkumar Ramachandra, Jun 18, 2013
  3. 2/8 wt-status: remove unused field in grab_1st_switch_cbdataRamkumar Ramachandra, Jun 18, 2013
  4. 3/8 t/checkout-last: test "checkout -" after a rebaseRamkumar Ramachandra, Jun 18, 2013
  5. 4/8 status: do not depend on rebase reflog messagesRamkumar Ramachandra, Jun 18, 2013
  6. Peter KreftingJun 18, 2013
  7. 5/8 checkout: respect GIT_REFLOG_ACTIONRamkumar Ramachandra, Jun 18, 2013
  8. Junio C HamanoJun 18, 2013
  9. Ramkumar RamachandraJun 18, 2013
  10. 6/8 sh-setup: make die_with_status clear GIT_REFLOG_ACTIONRamkumar Ramachandra, Jun 18, 2013
  11. Junio C HamanoJun 18, 2013
  12. Ramkumar RamachandraJun 18, 2013
  13. Junio C HamanoJun 18, 2013
  14. 7/8 rebase: write better reflog messagesRamkumar Ramachandra, Jun 18, 2013
  15. 8/8 rebase -i: write better reflog messagesRamkumar Ramachandra, Jun 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.