git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 8/8] rebase -i: write better reflog messages

From
Ramkumar Ramachandra <artagnon@gmail.com>
Date
Jun 18, 2013, 12:14 UTC
Message-ID
<1371557670-12534-9-git-send-email-artagnon@gmail.com>
In-Reply-To
<1371557670-12534-1-git-send-email-artagnon@gmail.com>

Now that the "checkout" invoked internally from "rebase -i" knows to honor GIT_REFLOG_ACTION, we can start to use it to write a better reflog message when "rebase -i anotherbranch", "rebase -i --onto branch", etc. internally checks out the new fork point. We will write:

  rebase -i (start): checkout master
instead of the old
  rebase -i (start)
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 git-rebase--interactive.sh | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index f953d8d..5179500 100644
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -326,6 +326,7 @@ pick_one_preserving_merges () {
 		if [ "$1" != "-n" ]
 		then
 			# detach HEAD to current parent
+			GIT_REFLOG_ACTION="$GIT_REFLOG_ACTION: checkout $first_parent"
 			output git checkout $first_parent 2> /dev/null ||
 				die "Cannot move HEAD to $first_parent"
 		fi
@@ -838,6 +839,7 @@ comment_for_reflog start
 
 if test ! -z "$switch_to"
 then
+	GIT_REFLOG_ACTION="$GIT_REFLOG_ACTION: checkout $switch_to"
 	output git checkout "$switch_to" -- ||
 		die "Could not checkout $switch_to"
 fi
@@ -981,6 +983,7 @@ has_action "$todo" ||
 
 test -d "$rewritten" || test -n "$force_rebase" || skip_unnecessary_picks
 
+GIT_REFLOG_ACTION="$GIT_REFLOG_ACTION: checkout $onto_name"
 output git checkout $onto || die_abort "could not detach HEAD"
 git update-ref ORIG_HEAD $orig_head
 do_rest
-- 
1.8.3.1.456.gb7f4cb6
Previous: Ramkumar Ramachandra
Message 15 of 15 in “Re-roll rr/rebase-checkout-reflog”
  1. 0/8 Re-roll rr/rebase-checkout-reflogRamkumar Ramachandra, Jun 18, 2013
  2. 1/8 t/status-help: test "HEAD detached from"Ramkumar Ramachandra, Jun 18, 2013
  3. 2/8 wt-status: remove unused field in grab_1st_switch_cbdataRamkumar Ramachandra, Jun 18, 2013
  4. 3/8 t/checkout-last: test "checkout -" after a rebaseRamkumar Ramachandra, Jun 18, 2013
  5. 4/8 status: do not depend on rebase reflog messagesRamkumar Ramachandra, Jun 18, 2013
  6. Peter KreftingJun 18, 2013
  7. 5/8 checkout: respect GIT_REFLOG_ACTIONRamkumar Ramachandra, Jun 18, 2013
  8. Junio C HamanoJun 18, 2013
  9. Ramkumar RamachandraJun 18, 2013
  10. 6/8 sh-setup: make die_with_status clear GIT_REFLOG_ACTIONRamkumar Ramachandra, Jun 18, 2013
  11. Junio C HamanoJun 18, 2013
  12. Ramkumar RamachandraJun 18, 2013
  13. Junio C HamanoJun 18, 2013
  14. 7/8 rebase: write better reflog messagesRamkumar Ramachandra, Jun 18, 2013
  15. 8/8 rebase -i: write better reflog messagesRamkumar Ramachandra, Jun 18, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.